update

backend/tests/test_parse.py

@@ -60,6 +60,21 @@ def test_parse_resolves_spell_damage():
     assert unit["spell_scaling"] == "ap"
 
 
+def test_resolve_spell_on_attack_passive():
+    diana_like = {
+        "desc": "<spellPassive>Passive:</spellPassive> Attacks deal "
+                "<magicDamage>@ModifiedBonusDamageToAttacks@ (%i:scaleAP%)</magicDamage> "
+                "bonus magic damage.",
+        "variables": [{"name": "BonusDamageToAttacks", "value": [0, 52, 78, 135, 230]}],
+    }
+    r = resolve_spell(diana_like)
+    assert r["spell_on_attack"] is True
+    assert r["spell_damage"] == [0, 52, 78, 135, 230]
+
+    cast = parse(RAW, set_override=17)["units"]["TFT17_Mage"]
+    assert cast["spell_on_attack"] is False
+
+
 def test_resolve_spell_adaptive_and_fallback():
     adaptive = {
         "desc": "Deal <magicDamage>@TotalDamage@</magicDamage> damage. %i:scaleAP% %i:scaleAD%",